Felix Held uploaded patch set #11 to the change originally created by HAOUAS Elyes.

View Change

src: Remove redundant use of ACPI offset(0)

IASL version 20180927 and greater, detects Unnecessary/redundant uses of
the Offset() operator within a Field Unit list.
It then sends a remark "^ Unnecessary/redundant use of Offset"

example:
    OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
    Field (OPR1)
    {
        Offset (0),     // Never needed
        FLD1, 32,
        Offset (4),     // Redundant, offset is already 4 (bytes)
        FLD2, 8,
        Offset (64),    // OK use of Offset.
        FLD3, 16,
    }

We will have those remarks:
dsdt.asl     14:         Offset (0),
Remark   2158 -                 ^ Unnecessary/redundant use of Offset operator

dsdt.asl     16:         Offset (4),
Remark   2158 -                 ^ Unnecessary/redundant use of Offset operator

Change-Id: I260a79ef77025b4befbccc21f5999f89d90c1154
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
---
M src/ec/compal/ene932/acpi/ec.asl
M src/ec/google/chromeec/acpi/ec.asl
M src/ec/google/chromeec/acpi/emem.asl
M src/ec/quanta/it8518/acpi/ec.asl
M src/ec/roda/it8518/acpi/ec.asl
M src/mainboard/facebook/monolith/acpi/ec.asl
M src/mainboard/lenovo/s230u/acpi/ec.asl
M src/mainboard/lippert/frontrunner-af/dsdt.asl
M src/soc/amd/picasso/acpi/globalnvs.asl
M src/soc/amd/stoneyridge/acpi/globalnvs.asl
M src/soc/intel/apollolake/acpi/globalnvs.asl
M src/soc/intel/baytrail/acpi/globalnvs.asl
M src/soc/intel/broadwell/pch/acpi/globalnvs.asl
M src/soc/intel/broadwell/pch/acpi/xhci.asl
M src/soc/intel/cannonlake/acpi/scs.asl
M src/soc/intel/denverton_ns/acpi/globalnvs.asl
M src/soc/intel/skylake/acpi/globalnvs.asl
M src/soc/intel/skylake/acpi/xhci.asl
M src/southbridge/amd/cimx/sb800/acpi/fch.asl
M src/southbridge/intel/bd82x6x/acpi/globalnvs.asl
M src/southbridge/intel/bd82x6x/acpi/pch.asl
M src/southbridge/intel/i82801ix/acpi/globalnvs.asl
M src/southbridge/intel/i82801ix/acpi/ich9.asl
M src/southbridge/intel/i82801jx/acpi/globalnvs.asl
M src/southbridge/intel/i82801jx/acpi/ich10.asl
M src/southbridge/intel/lynxpoint/acpi/globalnvs.asl
M src/southbridge/intel/lynxpoint/acpi/xhci.asl
M src/superio/fintek/f81803a/acpi/superio.asl
M src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbPcieAlibV1/PcieAlibCore.esl
M src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbPcieAlibV1/PcieAlibPciLib.esl
30 files changed, 10 insertions(+), 40 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/43283/11

To view, visit change 43283. To unsubscribe, or for help writing mail filters, visit settings.