Patch Set 1:

Maybe you would want to transform the PTN3460 code into a driver. The ptn3460.c file for mc_apl1, mc_apl4 and mc_apl5 only differs in a few comments and some config values. And if mc_apl5 is having issues without this patch, then mc_apl1 and mc_apl4 boards might have them as well.

Transferring the PTN code into a driver is planned for a long time already. Unfortunately fsp_baytrail does not have its i2c driver ready to be used as coreboots i2c bus (work is already ongoing) so that PTN code needs to be there at least for mc_tcu3. But we are on the way to sort it out.
mc_apl1 and mc_apl4 does not have the same issue as on these boards the LCD panel is fixed to the board and therefore the right EDID data is available at any time.

View Change

To view, visit change 35242. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0b9ed99fb78461bb48d6f2ff328643cd8c2cd15
Gerrit-Change-Number: 35242
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer@siemens.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer@siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 05 Sep 2019 05:48:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment