since the only function in nuvoton/common/hwm.c is a function wrapping another one, it might be a good idea to move that one into the header file as an inline function. if more or higher level functionality that is common for all winbond/nuvoton sio hwm units, those should be in the c file and only be linked in ramstage

View Change

To view, visit change 42130. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I103a4ea4cef24844d382854c9358bbb37d229e04
Gerrit-Change-Number: 42130
Gerrit-PatchSet: 12
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 20 Aug 2020 11:47:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment