Attention is currently required from: Lance Zhao, Maxim Polyakov, Jonathan Zhang.
View Change
1 comment:
Patchset:
Patch Set #41:
>Maybe the problem is in the wrong GPIO Community 1 range only? […]
There is a mapping in Linux between resource array and barNo.
In drivers/base/platform.c platform_get_resource(), it would look for
the resource by the array index from the parameter 'unsigned int num'.
Resource array is declared as ResourceTemplate in gpio.asl.
barNo is the index of the resource to be returned.
In this case: LBG_COMMUNITY(5, 181, 246),
kernel will look for resource through array index 5, if we don't add COM2 to ResourceTemplate(),
it will got the wrong resouce 'Interrupt' which causes returning error of invalid resource.
To view, visit change 39979. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07c882077eb3c035faae81641bc860e69db224b4
Gerrit-Change-Number: 39979
Gerrit-PatchSet: 44
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Andrey Petrov <anpetrov@fb.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 10:19:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Maxim Polyakov <max.senia.poliak@gmail.com>
Comment-In-Reply-To: Jonathan Zhang <jonzhang@fb.com>
Comment-In-Reply-To: Jingle Hsu <jingle_hsu@wiwynn.com>
Gerrit-MessageType: comment