6 comments:
SSPM is a Secure System Power Manager for
power control in secure domain.
Please use the full text width.
Patch Set #10, Line 11: is load
is to load
Patch Set #10, Line 11: SSPM firmware
Is that already in the 3rdparty repository?
File src/soc/mediatek/mt8183/sspm.c:
Patch Set #10, Line 35: die("SSPM file not found.");
As the name is in a variable, please print the name in the error message too.
is
/* Memory barrier to ensure that all fw code are loaded
* before we release the reset pin.
*/
Please follow the coding style.
/* …
… */
[1]: https://doc.coreboot.org/coding_style.html?highlight=coding#commenting
To view, visit change 31516. To unsubscribe, or for help writing mail filters, visit settings.