Patch Set 1: Code-Review+2

Non-PCI drivers can use 0 for uart_pci_addr (I think), but I'm not sure which ones those are, so everything is CONFIG_UART_PCI_ADDR for now.

nit: Can we just integrate that into lb_add_serial() instead? Saves one more line of boilerplate in all those drivers.

I don't particularly like how we encode PCI BDF for UART_PCI_ADDR like done in soc/intel/quark. We could do:

  uart_platform_pcidev(idx)
  {
     return PCI_DEV(0, 5, 5) | (1<<31)
  }

Then have weak declaration for the 0 case. The static Kconfig will not work if one happens to use add-on PCIe serial port, since bus number will be unknown.

Patch set 3:Code-Review -1

View Change

To view, visit change 34548. To unsubscribe, or for help writing mail filters, visit settings.