Patch set 21:Code-Review +1
10 comments:
File Documentation/mainboard/index.md:
Patch Set #21, Line 91: ## Portwell
Spurious?
File Documentation/mainboard/lenovo/t410_chip_location.jpg:
I think a closer image would be more helpful. I can barely see the chip
File src/mainboard/lenovo/t410/Kconfig:
Patch Set #21, Line 63: default 4
I think this should be 8
File src/mainboard/lenovo/t410/acpi/ec.asl:
Scope(\_SB.PCI0.LPCB.EC)
{
}
Maybe put the dock.asl EC code here?
File src/mainboard/lenovo/t410/acpi_tables.c:
static void acpi_update_thermal_table(global_nvs_t *gnvs)
{
gnvs->tcrt = CRITICAL_TEMPERATURE;
gnvs->tpsv = PASSIVE_TEMPERATURE;
}
Do we really need a function just for that?
File src/mainboard/lenovo/t410/devicetree.cb:
Maybe remove the empty comments
Maybe move to the previous line, and remove the "dummy" comment?
File src/mainboard/lenovo/t410/hda_verb.c:
I think you can remove all of these comments
File src/mainboard/lenovo/t410/romstage.c:
pci_write_config16(PCH_LPC_DEV, LPC_EN,
CNF2_LPC_EN | CNF1_LPC_EN | MC_LPC_EN | KBC_LPC_EN |
COMA_LPC_EN | GAMEL_LPC_EN);
Maybe reflow this so that it fits in two lines.
Also, if you select NO_UART_ON_SUPERIO, then COMA_LPC_EN doesn't make much sense I guess
/* This should probably go away. Until now it is required
* and mainboard specific
*/
This fits in one line, and there's two empty lines beforehand
To view, visit change 11791. To unsubscribe, or for help writing mail filters, visit settings.