Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Tristan Corrick: Looks good to me, approved
util/autoport: Make dsdt.asl prettier

Small cosmetic changes which fix aesthetic inaccuracies.

Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/30971
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tristan Corrick <tristan@corrick.kiwi>
---
M util/autoport/main.go
1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/util/autoport/main.go b/util/autoport/main.go
index 05a829b..dc02a8d 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -838,13 +838,14 @@

for _, define := range DSDTDefines {
if define.Comment != "" {
- fmt.Fprintf(dsdt, "\t/* %s. */\n", define.Comment)
+ fmt.Fprintf(dsdt, "\t/* %s. */\n", define.Comment)
}
dsdt.WriteString("#define " + define.Key + " " + define.Value + "\n")
}

dsdt.WriteString(
- `#include <arch/acpi.h>
+ `
+#include <arch/acpi.h>
DefinitionBlock(
"dsdt.aml",
"DSDT",
@@ -854,31 +855,29 @@
0x20141018 // OEM revision
)
{
- // Some generic macros
+ /* Some generic macros */
#include "acpi/platform.asl"
`)

for _, x := range DSDTIncludes {
if x.Comment != "" {
- fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment)
+ fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment)
}
fmt.Fprintf(dsdt, "\t#include <%s>\n", x.File)
}

dsdt.WriteString(`
- Scope (\_SB) {
- Device (PCI0)
- {
+ Device (\_SB.PCI0)
+ {
`)
for _, x := range DSDTPCI0Includes {
if x.Comment != "" {
- fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment)
+ fmt.Fprintf(dsdt, "\t/* %s. */\n", x.Comment)
}
fmt.Fprintf(dsdt, "\t\t#include <%s>\n", x.File)
}
dsdt.WriteString(
- ` }
- }
+ ` }
}
`)


To view, visit change 30971. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fef4bbe12b283cee2ab8d078de950171757bbfe
Gerrit-Change-Number: 30971
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged