Stefan Reinauer submitted this change.

View Change

trace/console: factor out error handling

Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Change-Id: I313dc6d3433921af38a7deea810dc51a45572ea6
Reviewed-on: https://review.coreboot.org/c/em100/+/48598
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M em100.c
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/em100.c b/em100.c
index c4b6c01..ffed4d7 100644
--- a/em100.c
+++ b/em100.c
@@ -1233,14 +1233,14 @@
 		printf(". Press CTL-C to exit.\n\n");
 
 		while (!exit_requested && usb_errors < MAX_USB_ERRORS) {
+			int ret;
 			if (trace) {
-				if (!read_spi_trace(em100, terminal,
-						address_offset))
-					usb_errors++;
+				ret = read_spi_trace(em100, terminal, address_offset);
 			} else {
-				if (!read_spi_terminal(em100, 0))
-					usb_errors++;
+				ret = read_spi_terminal(em100, 0);
 			}
+			if (ret == 0)
+				usb_errors++;
 		}
 		if (usb_errors >= MAX_USB_ERRORS)
 			printf("Error: Bailed out with too many USB errors.\n");

To view, visit change 48598. To unsubscribe, or for help writing mail filters, visit settings.