View Change

3 comments:

• File src/cpu/x86/smm/smm_module_handler.c:

  • Patch Set #1, Line 139: #ifdef CONFIG_STM

    no need for preprocessor

  • Patch Set #1, Line 178: MsegChk = rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX);

    delay the printk after console_init(). So you don't need to call it twice.

• File src/cpu/x86/smm/smm_stub.S:

  • Patch Set #1, Line 51: /* allows the STM to bring up SMM in 32-bit mode*/

    seems unsued

To view, visit change 33235. To unsubscribe, or for help writing mail filters, visit settings.