6 comments:
File src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/gpio.c:
Patch Set #6, Line 17: const struct pad_config *variant_gpio_table(size_t *num)
Maybe `configure_gpios()` then?
Hi Singer, thanks for reviewing. Since this is a copy code of mainboard, I don't wanna do it here. It'll be difficult to track all the changes here so this is just a copy patch and I will do relative changes as a separate patch sets in future.
Patch Set #6, Line 20: return gpio_table;
Why not just using `gpio_configure_pads(pads, num)` here? So you don't have to move data around
same as above
Patch Set #6, Line 23: const struct pad_config *variant_early_gpio_table(size_t *num)
`configure_early_gpios()`?
same as above
Patch Set #6, Line 26: return early_gpio_table;
Same here
same as above
Patch Set #6, Line 33: const struct cros_gpio *variant_cros_gpios(size_t *num)
`configure_cros_gpios()`?
same as above
Patch Set #6, Line 36: return cros_gpios;
Same here
same as above
To view, visit change 47707. To unsubscribe, or for help writing mail filters, visit settings.