Attention is currently required from: Evgeny Zinoviev, Felix Held.
Patch set 41:Code-Review +1
6 comments:
File src/mainboard/apple/macbookair5_2/Kconfig:
config MAX_CPUS
int
default 8
Shouldn't be necessary
Patch Set #41, Line 40: default "Apple Inc."
Sounds like `MAINBOARD_VENDOR` could be changed so that this isn't needed. But not in this patch.
File src/mainboard/apple/macbookair5_2/devicetree.cb:
Patch Set #41, Line 33: register "pcie_port_coalesce" = "1"
Is this actually needed?
File src/mainboard/apple/macbookair5_2/early_init.c:
const unsigned int
switch (ramcfg) {
case 0:
case 1:
spd_index = 0;
break;
case 2:
spd_index = 1;
break;
}
if (spd_index == -1)
die("Unsupported memory, RAMCFG=%d\n", ramcfg);
To avoid a signed-unsigned comparison in `get_spd_data()` between `int spd_index` and `spd_file_len`, the former variable can be made unsigned by refactoring the switch block as follows:
```
switch (ramcfg) {
case 0:
case 1:
spd_index = 0;
break;
case 2:
spd_index = 1;
break;
default:
die("Unsupported memory, RAMCFG=%u\n", ramcfg);
}
```
File src/mainboard/apple/macbookair5_2/spd/Makefile.inc:
Shouldn't this be `+=` instead?
To view, visit change 32604. To unsubscribe, or for help writing mail filters, visit settings.