Attention is currently required from: Angel Pons, Benjamin Doron, Christian Walter, Lean Sheng Tan, Leon Groß, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77905?usp=email )
Change subject: mb/emualtion: Add SIMICS QSP support
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/emulation/simics-qsp/northbridge.c:
https://review.coreboot.org/c/coreboot/+/77905/comment/fe478064_f556a35d :
PS7, Line 140: len += simics_get_smbios_data19(*handle + 2, *handle, current);
Any reason you're adding this here? All other boards use common code for type19
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77905?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I175b20bb4746608e4d868aa96492fc06c149bd36
Gerrit-Change-Number: 77905
Gerrit-PatchSet: 7
Gerrit-Owner: Leon Groß
leon.gross@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Leon Groß
leon.gross@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 31 Oct 2023 10:52:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment