Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55057 )
Change subject: arch/x86/include/bert_storage: rename bert_generate_ssdt ......................................................................
arch/x86/include/bert_storage: rename bert_generate_ssdt
Since it doesn't generate the SSDT, but only indicates if a SSDT should be generated, rename this to bert_should_generate_ssdt.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Suggested-by: Angel Pons th3fanbus@gmail.com Change-Id: If55cb54ee5f788e5a8d1fc4ececa9d8d4c2c51cf --- M src/arch/x86/include/arch/bert_storage.h M src/soc/amd/common/block/acpi/bert.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/55057/1
diff --git a/src/arch/x86/include/arch/bert_storage.h b/src/arch/x86/include/arch/bert_storage.h index 794fb83..527afcb 100644 --- a/src/arch/x86/include/arch/bert_storage.h +++ b/src/arch/x86/include/arch/bert_storage.h @@ -57,7 +57,7 @@ /* Find if errors were added, a BERT region is present, and ACPI table needed */ bool bert_errors_present(void); /* The BERT SSDT should only be generated when BERT support is enabled and there's an error */ -static inline bool bert_generate_ssdt(void) +static inline bool bert_should_generate_ssdt(void) { return CONFIG(ACPI_BERT) && bert_errors_present(); } diff --git a/src/soc/amd/common/block/acpi/bert.c b/src/soc/amd/common/block/acpi/bert.c index 9102715..81294c9 100644 --- a/src/soc/amd/common/block/acpi/bert.c +++ b/src/soc/amd/common/block/acpi/bert.c @@ -12,7 +12,7 @@ * a table with a 0-length region: * BERT: [Firmware Bug]: table invalid. */ - if (!bert_generate_ssdt()) + if (!bert_should_generate_ssdt()) return CB_ERR;
bert_errors_region(region, length);