13 comments:
Unknown soldered 8GB memory - SPD was extracted from BIOS image
(BIOS says it's Micron/2 ranks/13-15-15-34)
Which type of memory is it?
File src/mainboard/chuwi/Kconfig.name:
Patch Set #3, Line 2: CHUWI Innovation And Technology(ShenZhen)co.,Ltd
I'd just use "CHUWI"
File src/mainboard/chuwi/minibook/Makefile.inc:
Patch Set #3, Line 23: cbfs-files-y += ec.bin
This is hardcoded, and shouldn't be
File src/mainboard/chuwi/minibook/acpi/ec.asl:
I would recommend checking the ACPI DSDT of the vendor firmware.
File src/mainboard/chuwi/minibook/devicetree.cb:
Patch Set #3, Line 2: Enable
I don't think so
Watch out for copypasta mistakes
File src/mainboard/chuwi/minibook/dsdt.asl:
"COREv4", // OEM id
"COREBOOT", // OEM table id
I think there's definitions for these in arch/acpi.h
Patch Set #3, Line 28: //Platform
This comment doesn't add any value
Patch Set #3, Line 34: // CPU
Doesn't add anything of use either.
Scope (\_SB) {
Device (PCI0)
Device (\_SB.PCI0)
File src/mainboard/chuwi/minibook/hda_verb.c:
Patch Set #3, Line 23: /* Number of entries */
Please align these comments with tabs
File src/mainboard/chuwi/minibook/mainboard.c:
Are you using this file?
File src/mainboard/chuwi/minibook/spd/spd_util.c:
Patch Set #3, Line 47: /* They are valid, probably */
Defaults are valid only for some types of memory.
To view, visit change 38249. To unsubscribe, or for help writing mail filters, visit settings.