[coreboot-gerrit] Change in coreboot[master]: soc/tigerlake: Update early TCSS code to not call back and forth betw...

[Furquan Shaikh (Code Review)]

Attention is currently required from: Brandon Breitenstein.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )

Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc
......................................................................

Patch Set 2:

(1 comment)

File src/soc/intel/tigerlake/include/soc/early_tcss.h:

https://review.coreboot.org/c/coreboot/+/47684/comment/ff75bf79_fcf89826 
PS2, Line 141: mainboard_early_tcss_enable
> I accidentally added this in the next patch instead of updating it here will move that

Sounds good. BTW, I think the signature should be something like:

const struct tcss_mux *mainboard_get_tcss_mux_info(size_t *num_ports);

That way, it is clear that the mainboard is supposed to manage the space for the mux table. In the follow-up CLs, it looks like mainboard code is assuming SoC passes in a valid pointer and writes to NULL address.