Patrick Georgi submitted this change.
util/supermicro: Always include commonlib/bsd/compiler.h
We rely on `compiler.h` for definitions like `__packed`. Without it,
`smcbiosinfo.c` simply declared a global struct with that name, but
nothing was packed.
Found-by: reproducibility test
Change-Id: Ide055317115fc374a63812bcd3791445ca4f2dcc
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41784
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M util/supermicro/Makefile.inc
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/supermicro/Makefile.inc b/util/supermicro/Makefile.inc
index 1aa5bcb..316cb48 100644
--- a/util/supermicro/Makefile.inc
+++ b/util/supermicro/Makefile.inc
@@ -1,9 +1,11 @@
+TOOLCPPFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h
+
SMCBIOSINFOTOOL:= $(objutil)/supermicro/smcbiosinfo
$(SMCBIOSINFOTOOL): $(dir)/smcbiosinfo/smcbiosinfo.c
printf " HOSTCC Creating SMCBIOSINFO tool\n"
mkdir -p $(objutil)/supermicro
- $(HOSTCC) $< -o $@
+ $(HOSTCC) $(TOOLCPPFLAGS) $< -o $@
ifeq ($(CONFIG_VENDOR_SUPERMICRO),y)
ifneq ($(call strip_quotes, $(CONFIG_SUPERMICRO_BOARDID)),)
To view, visit change 41784. To unsubscribe, or for help writing mail filters, visit settings.