Attention is currently required from: Haribalaraman Ramasubramanian, Kapil Porwal, Nick Vaccaro, Shelley Chen, Subrata Banik.
Patch set 4:Code-Review -1
2 comments:
Commit Message:
This seems to make sense and allows us
to enable CNVi bluetooth when necessary.
I'm confused about 'when necessary' here. Both enabling the CNVI device and cnvi_bt_core and cnvi_bt_audio_offload are done via devicetree configuration. Do you want to have some mechanism at runtime to change them? If not then this is a step in the wrong direction and I'd suggest using build-time assertions (static_assert) rather than runtime ones.
Patchset:
I don't understand the rationale of weakening the asserts to just error message. Both config option and whether the device is enabled are known at compiletime, so making the assertion stronger, rather than weaker seems better?
To view, visit change 80504. To unsubscribe, or for help writing mail filters, visit settings.