Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )
Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... PS12, Line 47:
dev_offset can also be just maintained across the three loops. […]
Done
https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... PS12, Line 62: DevOffset
dev_offset
Done
https://review.coreboot.org/#/c/31284/12/src/soc/intel/cannonlake/fsp_params... PS12, Line 78: DevOffset
dev_offset
Done