Werner Zeh has uploaded this change for review.

View Change

mb/siemens/mc_ehl: Remove unneeded 'half_populated' variable

Since the DRAM population is fixed to both channels on all mc_ehl boards
there is no need to have this 'half_populated' variable at all.
Simply use a fixed 'false' in the call of 'memcfg_init()' and delete
this variable here.

Change-Id: I783c17e6d92322a8b0c094cce803108e718011fa
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
---
M src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
1 file changed, 1 insertion(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/58177/1
diff --git a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
index a6ed234..f93e0af 100644
--- a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
+++ b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
@@ -17,9 +17,6 @@
static uint8_t spd_data[0x100];
const char *cbfs_hwi_name = "hwinfo.hex";

- /* TODO: Read the resistor strap to get number of memory segments */
- bool half_populated = false;
-
/* Initialize SPD information for LPDDR4x from HW-Info primarily with a fallback to
spd.bin in the case where the SPD data in HW-Info is not available or invalid. */
memset(spd_data, 0, sizeof(spd_data));
@@ -35,5 +32,5 @@
spd_info.spd_spec.spd_index = 0x00;
}
/* Initialize variant specific configurations */
- memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, half_populated);
+ memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, false);
}

To view, visit change 58177. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I783c17e6d92322a8b0c094cce803108e718011fa
Gerrit-Change-Number: 58177
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com>
Gerrit-MessageType: newchange