6 comments:
File src/security/vboot/Kconfig:
same comments as patch 27
File src/security/vboot/vboot_crtm.c:
Patch Set #27, Line 249: if (!strcmp("COREBOOT", name) ||
mhhhhhhh? Where is the documentation?
I thought that was being done? It was a real question. If it isn't then I am mistaken.
File src/security/vboot/vboot_crtm.c:
Patch Set #28, Line 69: if (tpm_measure_region(&fmap, TPM_RUNTIME_DATA_PCR,
All these got moved to RUNTIME_DATA_PCR while some were CRTM_PCR (SI_DESC, SI_BE)
Patch Set #28, Line 179: static uint32_t is_runtime_data(const char *list, const char *name)
Probably rename this to something indicating it's now returning pcr index.
Patch Set #28, Line 187: // foo,blah,blub
?
Patch Set #28, Line 191: !memcmp(list, name, name_len))
strncmp might be better and let it not match if it encounters NUL or ','. What do you think? Seems more straight forward.
To view, visit change 31597. To unsubscribe, or for help writing mail filters, visit settings.