Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Michael Niewöhner, EricR Lai.
2 comments:
File src/soc/intel/alderlake/fsp_params.c:
Patch Set #42, Line 274: const struct pcie_rp_config *rp_cfg = &config->pch_pcie_rp[i];
Shouldn't there be a check here to ensure that the device is enabled? i.e. Get enable mask and skip the configuration if port is disabled?
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
Patch Set #42, Line 8: #define PCIE_RP(x) ((x) - 1)
Add a comment stating that PCIe root port numbers are 1-based, but we use 0-based indexes for the configuration arrays and so this macro subtracts 1 to convert RP# to array index.
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.