6 comments:
Is this really 3.3V? Its pulled up to 1.8V in schematics.
File src/mainboard/google/hatch/Kconfig:
Patch Set #5, Line 6: DRIVERS_GENERIC_MAX98357A
Can you please place this alphabetically before DRIVERS_I2C_GENERIC?
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
Patch Set #5, Line 247: register "probed" = "1"
Probed is not required here.
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
/* PCH_I2C_AUDIO_SDA */
PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1),
/* PCH_I2C_AUDIO_SCL */
PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1),
Can you please order these and the pins below as per GPP_* groups?
Patch Set #5, Line 163: * AUDIO IRQ
(HP_INT#)
Patch Set #5, Line 168: SPEAKER SD MODE ENABLE
Please use net name as comment so that its easier to compare with schematics.
To view, visit change 31280. To unsubscribe, or for help writing mail filters, visit settings.