View Change
1 comment:
Commit Message:
Patch Set #7, Line 9:
Currently, the PCIe bridge 00:15.2 is not detected by coreboot, causing
the connected network device also to be missing.
I guess commit messages are a topic we have rather different opinions on; I prefer the commit messag […]
Yeah, it looks like we do. But please take a look at `git log` of the Linux kernel. Commit messages shorter than eleven lines are – in my opinion luckily – are the exception, and a lot of logs are pasted in there.
To view, visit change 46527. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1d60a212b0d249c7d8b3f8ec16baf5e93c985da
Gerrit-Change-Number: 46527
Gerrit-PatchSet: 7
Gerrit-Owner: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1@gmail.com>
Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel@3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 20 Nov 2020 12:54:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment