Attention is currently required from: Kapil Porwal, Paul Menzel, Pranava Y N, Ronak Kanabar, Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84552?usp=email )
Change subject: soc/intel/pantherlake: Add FSP-S programming ......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/pantherlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/84552/comment/bdddf1b3_1e54732c?usp... : PS11, Line 250: static void fill_fsps_cpu_params(FSP_S_CONFIG *s_cfg, : const struct soc_intel_pantherlake_config *config) : { : const struct microcode *microcode; : size_t length; : : if (CONFIG(USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI)) : s_cfg->CpuMpPpi = (uintptr_t)mp_fill_ppi_services_data(); : : if (CONFIG(USE_FSP_FEATURE_PROGRAM_ON_APS)) { : /* Locate microcode and pass to FSP-S for 2nd microcode loading */ : microcode = intel_microcode_find(); : if (!microcode) : return; : : length = get_microcode_size(microcode); : if (!length) : return; : : /* Update CPU Microcode patch base address/size */ : s_cfg->MicrocodeRegionBase = (uint32_t)(uintptr_t)microcode; : s_cfg->MicrocodeRegionSize = (uint32_t)length; : } : }
- USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI <— FSP runs coreboot APIs
- USE_INTEL_FSP_MP_INIT <— FSP runs own APIs
in case #2 , filling the CpuMpPpi UPD won't harm.
That is simply not true. If `CpuMpPpi` is set while `USE_INTEL_FSP_MP_INIT=y` and `CONFIG_USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI=n` the FSP hit some exceptions inside coreboot MP functions because some initialization were not performed. If Is set to `NULL` which clearly is what is appropriate under this configuration when the CPU initialization execute just fine.
if you wish to use #2 (which we don't plan to use) then please select USE_INTEL_FSP_MP_INIT config.
I do not plan on changing the default configuration, this is just about setting the UPD appropriately.