Patch Set 5:

|> Still, you could fix the cpuid code first, then add SMBIOS 3.2 stuff. I don't see why it would have to be part of the same commit.
Removing the new core/tread procedure here and keeping everything else, along with the old core count in this commit would achieve the same goal, wouldn't it? If that is your request please confirm and I will do just that.

You can do that. My only request is that you don't fix
existing fields and call that required for the SMBIOS

|> I was mostly referring to the added fields that were left untouched (at 0) where 0 isn't a valid value. Sorry for the confusion.
There are 3 added field which are set to 0, and 0 indeed is a valid value for each of them. Please see these lines from the SMBIOS spec:
" A value of 0000h indicates the Memory Subsystem Controller Product ID is unknown"
" A value of 0000h indicates the Memory Subsystem Controller Manufacturer ID is unknown"
" A value of 0000h indicates the Module Product ID is unknown"
The FSP code have not yet been upgraded to 3.2 to popolate those memory fields appropriately. Hence their "unknown" 0 values.

That's in the past, see above "I *was* mosly referring". You
fixed that already, I know.

The fix for the existing field have been removed.
Please take a look.

View Change

To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 6
Gerrit-Owner: Francois Toguo Fotso <>
Gerrit-Reviewer: Francois Toguo Fotso <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Francois Toguo Fotso <>
Gerrit-CC: Lijian Zhao <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-Comment-Date: Fri, 29 Mar 2019 22:37:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment