Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32245 )
Change subject: mediatek: Use the 64-bit timer
......................................................................
Patch Set 5:
Note that this timer is also used in libpayload, so if you change it here, please make sure you also change it there (TIMER_GENERIC_REG and TIMER_GENERIC_HIGH_REG in payloads/libpayload/drivers/timer/Kconfig). Otherwise we may try to use the (then uninitialized) GPT4.
(FWIW we don't generally care about 32-bit roll-over in coreboot, because it doesn't have a use case where it should take anywhere near that long. But I'm fine with fixing this if you want to. In libpayload it's a bit more important because we may sit in recovery mode for a long time.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f080e47253a1b1bab4636a45cb86c8666a25302
Gerrit-Change-Number: 32245
Gerrit-PatchSet: 5
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 12 Apr 2019 18:27:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment