Attention is currently required from: Nico Huber, Matt DeVillier, Julius Werner.
View Change
1 comment:
Commit Message:
Patch Set #4, Line 7: [TEST]
I mean, I think that generally the "feature Kconfigs" should always have the same defaults everywher […]
While it might make sense to override some user-visible option default values on a per-mainboard basis (e.g. disable postcodes over LPC for a mainboard that does not expose LPC on any header or connector), I agree that it's most often a bad idea.
About CHROMEOS, I think Jenkins should fail to verify a change that overrides the default value. A way to implement this check would be to ensure the default config for all mainboards never contains CONFIG_CHROMEOS=y.
To view, visit change 49056. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae4bc22f70be5b8d8efa35f0cc8aa2d36a5531a
Gerrit-Change-Number: 49056
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Comment-Date: Tue, 02 Feb 2021 10:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier@gmail.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment