Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Paul Menzel, Angel Pons, Subrata Banik, Raj Astekar, Patrick Rudolph.
2 comments:
File src/cpu/x86/lapic/lapic_cpu_init.c:
I'm not 100%, but I thought the code here was abandoned in favor
of the mp_init version. If this is the case, the changes here are
probably untested and belong into a separate commit.
File src/cpu/x86/mp_init.c:
Patch Set #6, Line 458: } else {
Return 0 in the if-block and drop the `else`? This way, you don't need to reindent everything.
Or even better, add more functions. e.g. start_aps_lapic(), start_aps_lx2apic().
Only the call would have to be inside an if.
With a forward declaration the original code could even stay in
place, i.e. wouldn't show up much in the diff. If you want to
move it, that could be done in a later commit.
To view, visit change 51723. To unsubscribe, or for help writing mail filters, visit settings.