Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
View Change
2 comments:
Commit Message:
Patchset:
Patch Set #1:
Looking at the flow, do you think we should make an explicit call to initialize the GPIOs instead of doing it in the mainboard early init code? I don't think that smbus, lpc or the SPI init code actually touches the pins, but they could, so we'd want those to happen after the GPIO init as well.
To view, visit change 57291. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If02140aef56ed6db7ecee24811724b5b24e54a91
Gerrit-Change-Number: 57291
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martinroth@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Fri, 03 Sep 2021 14:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment