View Change
1 comment:
Commit Message:
Patch Set #6, Line 19: This means that when smm_do_relocation is executed, it is running in SMM
COOP_MULTITASKING doesn't change SMM code. It's only compiled into romstage/ramstage right now. […]
That's why I said "code compiled into SMM relocation". I don't care if it's
"ramstage code" in our build system. I'm still not sure if I fully understand
what is going on.
This combination of SMM relocation with code that calls cpu_info() is a new
corner case, right? To me it seems like that's an issue of the caller and
not of cpu_info(). Yet, your commit message states the opposite. IMO, we have
to be very careful about commit messages that state too bluntly that something
is broken. It will likely confuse people when they read the history later.
Please don't merge commits when the commit message is not clear yet. IMHO,
review can't even start before it is (unless the changes don't need any
explanation of course). If the background is not fully understood, reviewers
can't suggest alternatives, for instance.
To view, visit change 57627. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79dce9597cb784acb39a96897fb3c2f2973bfd98
Gerrit-Change-Number: 57627
Gerrit-PatchSet: 7
Gerrit-Owner: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Eric Peers <epeers@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Thu, 07 Oct 2021 14:36:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel@chromium.org>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment