Attention is currently required from: Yi Chou.
Patch set 3:Code-Review +2
2 comments:
File payloads/libpayload/arch/arm64/libpayload.ldscript:
Patch Set #3, Line 65: *(.bss.ttb_buffer)
I think you might as well remove this completely. We only need this for depthcharge since the whole BSS-erasing thing only happens in depthcharge. With this new approach, it's enough to do this only in the depthcharge linker script and let the default libpayload script subsume it under `.bss.*`.
File payloads/libpayload/arch/arm64/mmu.c:
Patch Set #3, Line 45: /* Don't chage the name of this variable without also changing the name in the
(Would need to change this text a bit then to explain that we refer to this in the linker script for ChormeOS's depthcharge payload and to please not change the name without discussing with us. Maybe put your email address as a contact.)
To view, visit change 79800. To unsubscribe, or for help writing mail filters, visit settings.