Refer to: https://review.coreboot.org/cgit/coreboot.git/tree/src/arch/x86/acpi_s3.c

The acpi_is_wakeup() function sets the acpi_slp_type global variable, and returns a value based on it. It is necessary to set that global variable correctly (hence a function call is needed), but no value needs to be returned.

I would suggest replacing acpi_is_wakeup() with acpi_handoff_wakeup() instead.

Patch set 1:Code-Review -1

View Change

To view, visit change 31140. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc57804074a58315e72e276fcae799febc10612d
Gerrit-Change-Number: 31140
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 29 Jan 2019 12:55:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment