Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Sridhar Siricilla: Looks good to me, but someone else must approve
mb/google/brya/variants/gimble: Disable PCIE RP 6 and TCSS Port 1

Gimble does not use WWAN and TCP Port 1 according to the schematics.
Hence disabling it.

BUG=b:216533766
TEST=Boot to kernel and verify WWAN and TCSS Port 1 disabled

Signed-off-by: Meera Ravindranath <meera.ravindranath@intel.com>
change-Id: I0e7ae72620da39fc18ff253c440d006e83c576f3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61266
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
---
M src/mainboard/google/brya/variants/gimble/overridetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb
index 23071fe..408d380 100644
--- a/src/mainboard/google/brya/variants/gimble/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb
@@ -38,6 +38,7 @@
register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Type-A MLB Port
register "usb2_ports[8]" = "USB2_PORT_EMPTY" # Type-A DB Port
register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A MLB port
+ register "tcss_ports[1]" = "TCSS_PORT_EMPTY"
# Intel Common SoC Config
#+-------------------+---------------------------+
#| Field | Value |
@@ -121,6 +122,7 @@
device generic 0 on end
end
end
+ device ref pcie_rp6 off end
device ref pcie_rp8 on
chip soc/intel/common/block/pcie/rtd3
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H13)"

To view, visit change 61266. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e7ae72620da39fc18ff253c440d006e83c576f3
Gerrit-Change-Number: 61266
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen@wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang@wistron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane.chen@intel.com>
Gerrit-CC: Malik Hsu <malik_hsu@wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Gerrit-MessageType: merged