[coreboot-gerrit] [M] Change in coreboot[master]: cpu/x86/cache: CLFLUSH programs to memory before running

[Subrata Banik (Code Review)]

Attention is currently required from: Raul Rangel, Nico Huber, Michał Żygowski, Subrata Banik, Reka Norman, Michał Kopeć, Angel Pons, Arthur Heymans, Felix Held.

Subrata Banik has uploaded a new patch set (#23) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/37196 )

Change subject: cpu/x86/cache: CLFLUSH programs to memory before running
......................................................................

cpu/x86/cache: CLFLUSH programs to memory before running

When cbmem is initialized in romstage and postcar placed in the stage
cache + cbmem where it is run, the assumption is made that these are
all in UC memory such that calling INVD in postcar is OK.

For performance reasons (e.g. postcar decompression) it is desirable
to cache cbmem and the stage cache during romstage.

Another reason is that AGESA sets up MTRR during romstage to cache all
dram, which is currently worked around by using additional MTRR's to
make that UC.

TESTED on asus/p5ql-em, up/squared on both regular and S3 resume
       bootpath. Sometimes there are minimal performance improvements
       when cbmem is cached (few ms).

Change-Id: I7ff2a57aee620908b71829457ea0f5a0c410ec5b
Signed-off-by: Arthur Heymans <[e-mail]>
---
M src/arch/x86/postcar_loader.c
M src/cpu/x86/Kconfig
M src/cpu/x86/Makefile.inc
A src/cpu/x86/cache/Makefile.inc
A src/cpu/x86/cache/cache.c
M src/include/cpu/x86/cache.h
6 files changed, 117 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/37196/23
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ff2a57aee620908b71829457ea0f5a0c410ec5b
Gerrit-Change-Number: 37196
Gerrit-PatchSet: 23
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Marshall Dawson <[e-mail]>
Gerrit-Reviewer: Martin L Roth <[e-mail]>
Gerrit-Reviewer: Michał Kopeć <[e-mail]>
Gerrit-Reviewer: Michał Żygowski <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Raul Rangel <[e-mail]>
Gerrit-Reviewer: Sean Rhodes <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Aaron Durbin <[e-mail]>
Gerrit-CC: Furquan Shaikh <[e-mail]>
Gerrit-CC: Marc Jones <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Reka Norman <[e-mail]>
Gerrit-Attention: Raul Rangel <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Michał Żygowski <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: Reka Norman <[e-mail]>
Gerrit-Attention: Michał Kopeć <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Attention: Felix Held <[e-mail]>
Gerrit-MessageType: newpatchset