Attention is currently required from: Angel Pons, Saurabh Mishra.

View Change

1 comment:

• File src/soc/intel/common/block/lpc/lpc.c:

  • Patch Set #1, Line 143: static const unsigned short pci_device_ids[] = {

    Yeah, we'd still need the IDs there. Fortunately, `report_platform.c` is SoC-specific, so the lists are not as long. It's also non-critical to function, so it would only impact the log output (which most non-developers won't see anyway).

    The main idea is to avoid having to potentially iterate over 300 IDs (worst-case) to try binding the ops to a device we always know is at PCI B:D.F `00:1f.0`.

    I would still like to keep this check as the PCI device ID check is a crucial mechanism in Linux to ensure the correct, safe, and efficient operation of a wide range of hardware devices. Skipping the check would introduce significant risks and limitations, undermining the stability and functionality of the system.

    for example: knowingly or unknowingly ppl can try to bind other device to LPC/eSPI driver results into mismatched drivers or incorrect resource allocation can lead to system instability, crashes, or even security vulnerabilities.

    coming to the data, 300 device id check for Intel latest SoC would take 207 microseconds roughly.

To view, visit change 83506. To unsubscribe, or for help writing mail filters, visit settings.