View Change
1 comment:
Commit Message:
Patch Set #1, Line 8:
This patch shortens macro names containing PCI_{DEVICE,VENDOR}_ID_
with PCI_{DID,VID}_.
Hi Felix, I appreciate the effort you're putting in to make the coreboot codebase better. […]
Hi, thanks for your comment!
I am not sure if this change is really worth it, because I don't know how much the other branches are used or how much backporting work is made. I am using master branch, mostly.
These are just names, so nothing special. I can live with that, if this patch is not getting merged. This is just an idea to reduce the characters count so that Jenkins is less complaining about exceeding the characters limit.
To view, visit change 39331. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9027700f53b6d0d3964c26a41a1f9b8f62be178
Gerrit-Change-Number: 39331
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martinroth@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 16 Mar 2020 17:13:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth@google.com>
Gerrit-MessageType: comment