Patch Set 2:
Patch Set 2:
@Intel: What unit does memory_info_hob->VddVoltage has? It's not documented.
i will review tomorrow
>> @Intel: What unit does memory_info_hob->VddVoltage has?
can you please look at https://github.com/coreboot/coreboot/blob/1470c7367b8fca24c86c8912aa65e969e63ff521/src/vendorcode/intel/fsp/fsp2_0/cometlake/FspmUpd.h#L305
unit is in volts
View Change
To view, visit change 33031. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6f0d4b223f1490ec7aa71a6105603635b514021
Gerrit-Change-Number: 33031
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Wed, 29 May 2019 04:55:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment