Patch set 3:Code-Review +1
8 comments:
Patch Set #3, Line 9: openssl
Ah, I see why it's not enabled by default
Patch Set #3, Line 19: image
ec_fw ?
Why noy use tabs everywhere?
const uint8_t CRC_TABLE[] = {0x00, 0x07, 0x0e, 0x09, 0x1c, 0x1b, 0x12, 0x15,
0x38, 0x3f, 0x36, 0x31, 0x24, 0x23, 0x2a, 0x2d};
nit: place the values in a new line?
const uint8_t CRC_TABLE[] = {
0x00, 0x07, 0x0e, 0x09, 0x1c, 0x1b, 0x12, 0x15,
0x38, 0x3f, 0x36, 0x31, 0x24, 0x23, 0x2a, 0x2d,
};
#define this?
#define this?
Patch Set #3, Line 152: fwTag
nit: fw_tag
Patch Set #3, Line 157: uint32_t
Casting this shouldn't be necessary
To view, visit change 41393. To unsubscribe, or for help writing mail filters, visit settings.