Subrata Banik has posted comments on this change. ( https://review.coreboot.org/18555 )
Change subject: soc/intel/apollolake: Code clean up to use soc/intel/common/block/cpu/car ......................................................................
Patch Set 23:
(5 comments)
https://review.coreboot.org/#/c/18555/23//COMMIT_MSG Commit Message:
Line 7: soc/intel/apollolake: Code clean up to use soc/intel/common/block/cpu/car
What do you do with the *code clean-up*? Revert? Do?
Done
PS23, Line 9: This patch to address below programming
Sorry, I don’t understand that sentence. Maybe:
Done
PS23, Line 10: 1. Use SOC_INTEL_COMMON_BLOCK_CAR to have common CAR initialization : and CAR teardown. : 2. Use common MSR header "intelblocks/msr.h" inside soc/cpu.h
Could the commit be split up to have one commit for each one of the enumera
sure paul, for future common code patch we will try to address this concern.
https://review.coreboot.org/#/c/18555/23/src/soc/intel/apollolake/Kconfig File src/soc/intel/apollolake/Kconfig:
Line 257:
Unrelated change.
i don't understand this comments. did you mean why added new line? I think it was already there.
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/apollolake/Kc...
PS23, Line 286: Tear Down
lowercase: tear down
Done