Nice work. Can the QEMU Q35 change be factored out?
7 comments:
Patch Set #8, Line 25: keyword to sconfig
Strange line break. Could you reformat the whole message for 75 characters, please?
Patch Set #8, Line 339: bool "Enable a configurable ramstage."
Please remove the dot at the end.
The minimal PCI scanning will only check those parts that are enabled
in the devicetree.cb. By convention none of those devices should be bridges.
Move this to the description of the option below?
File src/include/device/device.h:
Remove for concise multi-line comments.
File util/sconfig/lex.yy.c_shipped:
Patch Set #8, Line 9: #define YY_FLEX_SUBMINOR_VERSION 4
Why increment it by 3?
File util/sconfig/sconfig.tab.c_shipped:
Patch Set #8, Line 112: #ifndef YY_YY_HOME_RMINNICH_PROJECTS_LINUXBOOT_COREBOOTNERF_GITHUBCOREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED
Is this wanted?
File util/sconfig/sconfig.tab.h_shipped:
Patch Set #8, Line 33: #ifndef YY_YY_HOME_RMINNICH_PROJECTS_LINUXBOOT_COREBOOTNERF_GITHUBCOREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED
Ditto.
To view, visit change 36221. To unsubscribe, or for help writing mail filters, visit settings.