17 comments:
File src/soc/qualcomm/common/include/soc/sn65dsi86bridge.h:
Patch Set #13, Line 99: enum vstream_config{
missing space after enum definition
Patch Set #13, Line 112: enum i2c_over_aux{
missing space after enum definition
Patch Set #13, Line 113: I2C_OVER_AUX_WRITE_MOT_0 ,
space prohibited before that ',' (ctx:WxE)
File src/soc/qualcomm/common/sn65dsi86bridge.c:
Patch Set #13, Line 40: #define DP_BRIDGE_DPCD_REV 0x700
please, no space before tabs
Patch Set #13, Line 49: #define DP_MAX_LINK_RATE 0x001
please, no space before tabs
Patch Set #13, Line 55: #define DP_LINK_BW_1_62 0x06
please, no space before tabs
Patch Set #13, Line 85: i2c_writeb(I2C_BUS, CHIP, SN_AUX_ADDR_15_8_REG, (dpcd_reg >> 8) & 0xFF );
space prohibited before that close parenthesis ')'
Patch Set #13, Line 145: printk(BIOS_ERR,"No matching eDP rates in table; falling back\n");
space required after that ',' (ctx:VxV)
Patch Set #13, Line 188: uint64_t pixel_clk ;
space prohibited before semicolon
Patch Set #13, Line 211: uint64_t dp_rate_mhz ;
space prohibited before semicolon
Patch Set #13, Line 273: if (!wait_us(500000,(!(i2c_readb(I2C_BUS, CHIP, SN_DPPLL_SRC_REG, &buf)) &&
suspect code indent for conditional statements (8, 24)
Patch Set #13, Line 273: if (!wait_us(500000,(!(i2c_readb(I2C_BUS, CHIP, SN_DPPLL_SRC_REG, &buf)) &&
space required after that ',' (ctx:VxV)
Patch Set #13, Line 275: printk(BIOS_ERR,"PLL lock failure");
space required after that ',' (ctx:VxV)
Patch Set #13, Line 290: if (!wait_us(500000,(!(i2c_readb(I2C_BUS, CHIP, SN_ML_TX_MODE_REG, &buf)) &&
space required after that ',' (ctx:VxV)
Patch Set #13, Line 292: printk(BIOS_ERR,"Link training failed");
space required after that ',' (ctx:VxV)
Patch Set #13, Line 358: i2c_write_field(I2C_BUS, CHIP, SN_SSC_CONFIG_REG, MIN(data,3), 3, 4);
space required after that ',' (ctx:VxV)
adding a line without newline at end of file
To view, visit change 39615. To unsubscribe, or for help writing mail filters, visit settings.