Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35174 )
Change subject: mb/google/poppy/variant/nocturne: add EC_SYNC_GPIO ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... File src/mainboard/google/poppy/chromeos.c:
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... PS5, Line 35: CONFIG(BOARD_GOOGLE_NOCTURNE)
#ifdef EC_SYNC_GPIO? […]
Good idea.
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/c/coreboot/+/35174/5/src/mainboard/google/poppy/... PS5, Line 199: PAD_CFG_GPI_APIC_INVERT
Just curious: If you are just passing the GPIO# to depthcharge from coreboot, does this INVERT reall […]
It does not make a difference for the functionality in depthcharge. Volume buttons work in depthcharge either way.