5 comments:
File src/mainboard/unk/gbyt4/acpi/mainboard.asl:
Patch Set #1, Line 3: Scope (\_SB.PCI0.LPEA)
This is for LPE audio, if the board doesn't have any audio support, then I'd drop it
I can delete the GpioInt lines but the ResourceTemplate needs to remain otherwise it doesn't build.
File src/mainboard/unk/gbyt4/cmos.layout:
Patch Set #1, Line 12: #96 4 r 0 status_c_rsvd
You can drop all commented-out entries. They can only bitrot 😄 […]
I will drop them. And they also should be dropped from google/rambi and many other boards with the exact same file copy pasted.
# SandyBridge MRC Scrambler Seed values
896 32 r 0 mrc_scrambler_seed
928 32 r 0 mrc_scrambler_seed_s3
Not Sandy Bridge
Should it be renamed to BayTrail or dropped entirely?
File src/mainboard/unk/gbyt4/devicetree.cb:
I see there's only one SATA port, but I'm fairly sure the mPCIe slot is actually mSATA (Bay Trail on […]
I will change it to 3, just the comment i copied along with the base device tree from rambi (incorrectly) suggested that it meant two.
on […]
From the data sheet it looks like it's a different SPI controller not the same as the flashchip is on (e.g. SIO SPI vs PCU SPI).
To view, visit change 43087. To unsubscribe, or for help writing mail filters, visit settings.