View Change

5 comments:

• File src/mainboard/intel/common/board/board_id.c:

  • Patch Set #4, Line 24: uint32_t

    why use a variable of different signature from the return type?

    Done

  • Patch Set #4, Line 38:

    if (CONFIG(EC_GOOGLE_CHROMEEC))
    			id = get_board_id_via_ext_ec();
    		else
    

    use brackets on if condition too.

    Done

  • Patch Set #4, Line 40: {

    space before.

    Done

  • Patch Set #4, Line 45: buffer[index] = recv_ec_data();

    id |= recv_ec_data() << (8 * (1 - index)); after clearing id?

    Current one looks cleaner, can we keep as is?

• File src/mainboard/intel/common/memory/spd.c:

  • Patch Set #4, Line 23:

    remove newline.

    Done

To view, visit change 37707. To unsubscribe, or for help writing mail filters, visit settings.