Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40754 )
Change subject: amd/agesa/hudson boards: Get rid of power button device ......................................................................
Patch Set 4:
Patch Set 4: Code-Review+1
f15tn: both Lenovo G505S and ASUS A88XM-E boot fine with this patch. I did a similar change for f16kb ASUS AM1I-A (see below) - and it also boots fine. +1 only because I suspect this patch is incomplete (not for all the boards with such a code), but I'm not confident enough to amend this change.
diff --git a/src/mainboard/asus/am1i-a/dsdt.asl b/src/mainboard/asus/am1i-a/dsdt.asl index 4000d61538..8544c97da2 100644 --- a/src/mainboard/asus/am1i-a/dsdt.asl +++ b/src/mainboard/asus/am1i-a/dsdt.asl @@ -36,13 +36,6 @@ DefinitionBlock ( /* Describe IRQ Routing mapping for this platform (within the _SB scope) */ #include "acpi/routing.asl"
Device(PWRB) {
Name(_HID, EISAID("PNP0C0C"))
Name(_UID, 0xAA)
Name(_PRW, Package () {3, 0x04})
Name(_STA, 0x0B)
}
Device(PCI0) { /* Describe the AMD Northbridge */ #include <northbridge/amd/agesa/family16kb/acpi/northbridge.asl>
Thanks. My plan is to submit separate change-sets for that.