Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47017 ) Change subject: soc/intel/common: Have weak implementation for do_global_reset() ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/47017/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/47017/1//COMMIT_MSG@9 PS1, Line 9: Not all IA SoC
Which ones do not implement do_global_reset()? Why not implement it on the SoCs that do not have it […] I agree with Angel here, a weak no-op reset function is hazardous...
-- To view, visit https://review.coreboot.org/c/coreboot/+/47017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I934b41affed7bb146f53ff6a4654fdbc6626101b Gerrit-Change-Number: 47017 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Subrata Banik <subi.banik@gmail.com> Gerrit-Comment-Date: Fri, 30 Oct 2020 22:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment