View Change

2 comments:

• File src/cpu/x86/16bit/entry16.inc:

  • Patch Set #6, Line 134: #else

    given that you just want to avoid setting 2 bits depending on the bootguard bit, how about the following?

    	movl	%cr0, %ebx
    	andl	$0x7FFAFFD1, %ebx /* PG,AM,WP,NE,TS,EM,MP = 0 */
    	orl	$0x60000001, %ebx /* CD, NW, PE = 1 */

    
    #if CONFIG(BOOTGUARD_CACHE_ENABLE)
    	/* DO NOT disable cache if Intel BootGuard is supported */
    	movl $BOOTGUARD_MSR, %ecx
    	rdmsr
    	test	$1, %eax
    	jz	1f
    	andl	~$(0x60000000), %ebx
    1:
    #endif

    	movl	%ebx, %cr0

• File src/cpu/x86/Kconfig:

  • Patch Set #6, Line 188: BOOTGUARD_CACHE_ENABLE

    Do you expect to need other Kconfig symbols depending on MAINBOARD_HAS_BOOT_GUARD? Otherwise it seems a bit moot to have 2 symbols?

To view, visit change 38252. To unsubscribe, or for help writing mail filters, visit settings.