i don't see a reason why AHCI should be disabled on ICHs that support AHCI; just want the confirmation that the changes are intended and probably won't make a difference

View Change

10 comments:

• File src/mainboard/asus/p5gc-mx/devicetree.cb:

  • Patch Set #9, Line 56:

    does the ICH on this board support AHCI?

• File src/mainboard/foxconn/g41s-k/devicetree.cb:

  • Patch Set #9, Line 50:

    does this change behavior?

• File src/mainboard/getac/p470/devicetree.cb:

  • Patch Set #9, Line 60:

    same question here

• File src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb:

  • Patch Set #9, Line 79:

    same question here

• File src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb:

  • Patch Set #9, Line 51:

    same question here

• File src/mainboard/intel/d945gclf/devicetree.cb:

  • Patch Set #9, Line 53:

    same question here

• File src/mainboard/kontron/986lcd-m/devicetree.cb:

  • Patch Set #9, Line 39:

    same question here

• File src/mainboard/roda/rk886ex/devicetree.cb:

  • Patch Set #9, Line 64:

    same question here

• File src/southbridge/intel/i82801gx/sata.c:

  • Patch Set #9, Line 58: likely

    to be able to use additional functions of a pci device, function 0 has to be enabled

  • Patch Set #9, Line 63: return;

    is it correct that pci_write_config8(dev, SATA_MAP, pci_read_config8(dev, SATA_MAP) & ~0xc3) doesn't get run in this case? this is at least a difference to the previous the code flow.

To view, visit change 30822. To unsubscribe, or for help writing mail filters, visit settings.