Sorry, some things slipped through my earlier review. Some
reasoning for the BERT issue: I think if the address is used
as a pointer in a subsystem, we shouldn't drag `uintptr_t`
into it. A nit, though, as our ACPI code is full of `unsigned
long` for addresses.

We are on the right track, I think:
$ # removed casts to pointers:
$ git show | grep '^-.*\*)' | wc -l
69
$ # added casts to pointers
$ git show | grep '^+.*\*)' | wc -l
7

Six of the latter are actually unnecessary, they were three,
unrelated casts before. So we could get the added count down
to 1, the cast for/in BERT.

I understand that this is hard to split up (would add a lot
of intermediate casts). Maybe, to reduce the round-trip time,
I could fix my comments by myself and we review both?

View Change

16 comments:

To view, visit change 30684. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ef5d9fad0298c79806fd94ca053027822022ac2
Gerrit-Change-Number: 30684
Gerrit-PatchSet: 16
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Damien Zammit <damien@zamaudio.com>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin@intel.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp@hug.cx>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: York Yang <york.yang@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 23 Feb 2019 14:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment